search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 161 forks source link

HoldTillRename: Rename knative-sandbox to knative-extension #3837

Closed davidhadas closed 1 year ago

davidhadas commented 1 year ago

This is an automated PR to replace knative-sandbox strings to knative-extension. Do not merge until Rename knative-sandbox org is renamed to knative-extension

See https://github.com/knative/community/issues/169

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidhadas Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
krsna-m commented 1 year ago

unit tests are giving valid failures. Please review the test failures

knative-prow-robot commented 1 year ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
davidhadas commented 1 year ago

@kvmware - not sure what we need to do here next. The new PR deletes prow/jobs/generated/knative-sandbox, I can reintroduce it and only add prow/jobs/generated/knative-extension Yet, whenever we will merge this PR, prow/jobs/generated/knative-extension will be an old one... so maybe we need to make this PR only after we rename...

krsna-m commented 1 year ago

Please see: https://cloud-native.slack.com/archives/C04LGHDR9K7/p1684430739022769