search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 164 forks source link

buoy: cut extra URL path for module #3848

Closed nak3 closed 12 months ago

nak3 commented 12 months ago

Some module use sub-directory for the module like https://github.com/blang/semver/tree/master/v4

In that case, buoy fails to fetch metadata with the full path:

$ curl https://github.com/blang/semver/v4?go-get=1

so needs to use the top directory and path.

$ curl https://github.com/blang/semver?go-get=1

Hence, this patch cuts extra URL path for module.

knative-prow[bot] commented 12 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nak3 Once this PR has been reviewed and has the lgtm label, please assign cardil for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
krsna-m commented 12 months ago

as discussed in slack please make changes to respected repo https://github.com/knative/toolbox/tree/main/buoy