search

knative / website

Hugo templates for the Knative website.
https://knative.dev
Other
23 stars 70 forks source link

Upgrade to Hugo 0.74.3, fix knative/docs#2706 #200

Closed evankanderson closed 4 years ago

evankanderson commented 4 years ago

Fixes https://github.com/knative/docs/issues/2706

Follow on to #196

Deploy preview: https://deploy-preview-196--knative.netlify.app/

Sample page from https://github.com/knative/docs/issues/2706

https://deploy-preview-196--knative.netlify.app/docs/eventing/samples/kubernetes-event-source/#deployment-steps

Compare with:

https://knative.dev/docs/eventing/samples/kubernetes-event-source/#deployment-steps

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/website/blob/master/OWNERS)~~ [evankanderson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
evankanderson commented 4 years ago

This needs #198 to merge first.

evankanderson commented 4 years ago

/hold

evankanderson commented 4 years ago

Fixes https://github.com/knative/docs/issues/2706

RichieEscarez commented 4 years ago

This needs a rebase (even though Prow thinks otherwise). These errors are causing the build to fail:

2:07:21 PM: Building sites … WARN 2020/08/17 21:07:21 Page.Dir is deprecated and will be removed in a future release. Use .File.Dir
2:07:30 PM: Total in 10079 ms
2:07:30 PM: Error: Error building site: TOCSS: failed to transform "scss/main.scss" (text/x-scss): SCSS processing failed: file "stdin", line 8, col 1: File to import not found or unreadable: ../vendor/Font-Awesome//web-fonts-with-css/scss/fontawesome.scss.
evankanderson commented 4 years ago

/hold cancel