search

knative / website

Hugo templates for the Knative website.
https://knative.dev
Other
23 stars 70 forks source link

Apply Docsy updates from the upstream #226

Closed tnir closed 4 years ago

tnir commented 4 years ago

Improves user experience on mobile screens.

cf. google/docsy#344

Closes #224

knative-prow-robot commented 4 years ago

Welcome @tnir! It looks like this is your first PR to knative/website 🎉

tnir commented 4 years ago

/assign @tcnghia

tcnghia commented 4 years ago

It looks a lot better on mobile with the new smaller margin (https://deploy-preview-226--knative.netlify.app vs https://knative.dev). Thanks for the change. /approve

@abrennan89 can you please also take a look? thanks

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tcnghia, tnir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/website/blob/master/OWNERS)~~ [tcnghia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
RichieEscarez commented 4 years ago

I dont have time to test this today but I want to add that this update also picks up the recently added "click to copy" feature too (and fixes #57).

RichieEscarez commented 4 years ago

Clicking around in the staged version looks great (though ive not done it throughly). I would say the other thing to verify is that the local builds run fine too.

And... Thanks @tnir !

tcnghia commented 4 years ago

@RichieEscarez I think the local build is validated in the workflow. Check out https://deploy-preview-226--knative.netlify.app

tcnghia commented 4 years ago

/lgtm

RichieEscarez commented 4 years ago

The localbuild.sh scripts work perfectly!

@tcnghia FYI, the local build uses Hugo and the Hugo server to run similar build scripts while the preview (linked above) is built through Hugo and Netlify. In the past, these builds did not behave the same and that led to lots of issues in our site. We might be past that now and I do hope thats the case but I still like to test that before we merge since not only do some contributors regularly use the localbuild.sh scripts but also one of our bots in the knative/docs repo uses it.

Thanks again @tnir (im also looking forward to trying out the click-to-copy feature and eventually adding that throughout our docs)

tcnghia commented 4 years ago

Thanks @RichieEscarez for explaining!