knative / website

Hugo templates for the Knative website.
https://knative.dev
Other
23 stars 70 forks source link

Fix mac errors for local server #233

Closed RichieEscarez closed 3 years ago

RichieEscarez commented 4 years ago

Disable live reload for the Hugo server by default (LIVERELOAD="--watch=false --disableLiveReload"). Docs get copied and fixed by the script so live reload is not useful for building only the docs. This also fixes the "too many files open" error in Macs when running the Hugo server.

Add option to enable live reload (ie for when modifying the site itself): localbuild.sh -s reload For Macs, this will cause the "too many files open" error.

Updated the instructions.

RichieEscarez commented 3 years ago

@evankanderson or @mattmoor

If one of you get a free moment can you PTAL and help me merge this change? It's been working flawlessly for me over the last couple of weeks.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/website/blob/master/OWNERS)~~ [RichieEscarez,evankanderson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment