Write a tool to automatically fill out the go mod redirects

knative / website

Hugo templates for the Knative website.

https://knative.dev

Other

23 stars 70 forks source link

Write a tool to automatically fill out the go mod redirects #237

Closed evankanderson closed 3 years ago

evankanderson commented 3 years ago

This generates a bunch more redirects than we have, standardizes the format, and I think fixes the sample-controller import.

I wasn't quite sure what effect putting a go.mod at the top-level would have, so put it next to the tool, but I'd like some opinions.

/assign @mattmoor @n3wscott @RichieEscarez

Next step:

Figure out how to run this as a nightly action proposing PRs.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/website/blob/master/OWNERS)~~ [evankanderson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

mattmoor commented 3 years ago

/lgtm /hold

Holding in case you want more eyeballs on this. If you make ./hack/update-codegen.sh run this then two nice things will happen:

Verify codegen will block submits that break this, and
You'll automatically start getting nightly PRs (if website were in the mix, which is might not be)

RichieEscarez commented 3 years ago

looks like this is working = Everything in the /static folder is getting published to the site, and the /tools folder isn't (or at least not causing anything to break)

/lgtm

evankanderson commented 3 years ago

I'll probably do the ./hack/update-codegen.sh as a separate PR, thanks for the tip!

evankanderson commented 3 years ago

/hold cancel