search

knative / website

Hugo templates for the Knative website.
https://knative.dev
Other
23 stars 70 forks source link

Add an update-codegen to regenerate the static redirects. #239

Closed evankanderson closed 3 years ago

evankanderson commented 3 years ago

I also noticed a bug in redir-gen that we weren't going through list pagination, and so missed several repos.

/assign @mattmoor

I think adding ./hack/update-codegen.sh will cause nightly PRs to update when needed, but won't block other PRs with requiring this to be regenerated. Is that correct?

mattmoor commented 3 years ago

@evankanderson We probably need to add knative/website to repos.yaml in knative-sandbox/knobots for the daily PRs, I don't think it ever made the list.

For the verify-codegen presubmit check, the action sync should take care of that (once the actions land here) 🤞

evankanderson commented 3 years ago

I'm not sure we want a verify for these redirects, because they vary based on external factors (what repos have been created), and I'm not sure that we want to block PR submits because a new repo got created somewhere. Given that, I think just an update-codegen.sh is appropriate.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/website/blob/master/OWNERS)~~ [evankanderson,mattmoor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment