Update build scripts to build from any named docs fork

knative / website

Hugo templates for the Knative website.

https://knative.dev

Other

23 stars 70 forks source link

Update build scripts to build from any named docs fork #242

Closed RichieEscarez closed 3 years ago

RichieEscarez commented 3 years ago

All knative/docs PRs get automatically built into preview sites here: https://app.netlify.com/sites/knative/deploys

The first build scripts made many assumptions to get all things working / up-and-running.

These changes add the following enhancements:

Forks can be renamed and no longer must match the knative repo/docs (richieescarez/docs). Example: ricardozanini/knative-docs
A fork of knative/community is optional. Build will default to the master branch of knative/community.
Moved the Build Details closer to the top of the build logs to make it easier to locate the PR#

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/website/blob/master/OWNERS)~~ [RichieEscarez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

RichieEscarez commented 3 years ago

This is all working locally but I want to test more to ensure Netlify is completely happy too.

RichieEscarez commented 3 years ago

Testing successful! This is ready to go in.

Last commit: Removed a non-blocking (no errors) production build error message = Ensure clear production build logs.

Otherwise this is working as expected on my mock Nelify / Knative build using a couple of my repo forks:

Renamed knative/docs forks are now supported, like: ireneorichie/docs-testforkname

Non-existant /community forks default to knative/community:

7:40:10 PM: No /community fork found in ireneorichie
7:40:10 PM: Building from the master branch of knative/community

View the test PR build output (mock Netlify/Knative build): https://5fd04629a73e1000078b806c--knative-v1.netlify.app/docs/

abrennan89 commented 3 years ago

Awesome! Thank you so much @RichieEscarez :partying_face: /lgtm