Closed sbawaska closed 2 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sbawaska
To complete the pull request process, please assign carieshmarie after the PR has been reviewed.
You can assign the PR to them by writing /assign @carieshmarie
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Welcome @sbawaska! It looks like this is your first PR to knative/website 🎉
I am extremely curious on the click rate for this button.
Even if this ends up being not the "ideal" solution in the long-run, the data behind how many folks click that button would be helpful.
For a next iteration of this experiment, we may want to move the "In-Browser" tutorial to live on the Knative site and measure time-on-site as a result of this change.
EDIT: This is under the assumption that this will not be living on the Knative site? I assume this links out to Katacoda?
@sbawaska can we embed Katacoda into the website...?
Adding the TOC for this type of change.
Once upon a time there were lots of non Knative specific docs and code samples throughout the Knative docs library but that caused tons of maintenance issues among other things. Today there are these two sections that we have for linking to external tutorials/docs/codes samples:
https://knative.dev/docs/samples/#external-code-samples https://knative.dev/community/samples/
Im not familiar with Katacoda but this feels like something different (maybe a new or different section?). I'd like the TOC to discuss and drive the guidelines about what and when to open the door to adding content to the main Knative page.
@sbawaska can we embed Katacoda into the website...?
@omerbensaadon embedding is only allowed as a paid subscription.
@RichieEscarez and TOC members: This change is in line with what Tekton does on their home page. The links highlighted in the screen shot point to katacoda tutorials.
The PR for the tutorials has now been merged knative/docs#3142
@sbawaska the entire website has meanwhile moved over to https://github.com/knative/docs/. Do you mind moving this over if you'd still want to do this?
This links to the katacoda tutorials that are pending merge: https://github.com/knative/docs/pull/3142