knative / website

Hugo templates for the Knative website.

https://knative.dev

Other

23 stars 70 forks source link

Remove README->index renames #259

Closed evankanderson closed 3 years ago

evankanderson commented 3 years ago

Changes

🧹 Remove renames of README.md to _index.md or index.md. Instead, just report in the build script if this happens, so we can clean them up. Simplifies the build process and makes it easier to (for example) just build directly from the sources instead of needing additional pre-processing.
Fixes #https://github.com/knative/docs/pull/3286 Fixes #230

evankanderson commented 3 years ago

/hold

I don't want to submit this until after I see what the Netlify build looks like/complains about.

evankanderson commented 3 years ago

4:01:22 PM: ------ CONVERT FULLY QUALIFIED REPO URLS TO RELATIVE ------
4:01:22 PM: Converting all fully-qualified Knative URLs to relative URLs...
4:01:24 PM: Converting all links in GitHub source files to Hugo supported relative links...
4:01:26 PM: Converting all standalone README.md files to index.md...
4:01:27 PM: BARE README AT opt/build/repo/content/en/third_party/VENDOR-LICENSE/github.com/eclipse/paho.mqtt.golang, WILL NOT BE RENDERED.
4:01:27 PM: Copying the override files into the /content/ folder

/approve /unhold

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/website/blob/master/OWNERS)~~ [evankanderson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

evankanderson commented 3 years ago

Sample site (including community) seems to be working okay:

https://deploy-preview-259--knative.netlify.app/

abrennan89 commented 3 years ago

/lgtm YOLO