Closed RichieEscarez closed 3 years ago
/hold
We should sync this PR too: https://github.com/knative/website/pull/263
@evankanderson this should be ready to go and will fix all the PR builds too (re: master/main rename): https://app.netlify.com/sites/knative/deploys
Friendly ping.
Can someone please help merge this (merge conflict resolution is becoming a time sink)?
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: omerbensaadon, vaikas
The full list of commands accepted by this bot can be found here.
The pull request process is described here
A step I forgot to mention for the Docs release process:
git reset --hard upstream/main
A regular task that needs to be done is to sync the Main and Staging branches.
Re: How docs builds work: https://knative.slack.com/archives/C9CV04DNJ/p1614635312040400
This add more detail around how the webhooks work:
['main' branch of knative/website]
['staging' branch of knative/website]
Netlify is configured to only run a "production" build if that build is from the 'main' branch of knative/website. The 'staging' branch in knative/website is the build that all PRs run ("preview" builds). The webhooks sent from knative/docs are simply configured to indicate which knative/website branch to use for each build.
More info: The build configuration for "preview" builds are here and here, which builds the site from the PR owners single branch and fork only. Therefore, the knative/website branches can drift out of sync without negative affects but I try not to let them drift too far.