search

knative / website

Hugo templates for the Knative website.
https://knative.dev
Other
23 stars 70 forks source link

Add future Docs release owners as Approvers #264

Closed RichieEscarez closed 3 years ago

RichieEscarez commented 3 years ago

Add @csantanapr and @omerbensaadon to docs approvers list to ensure they are not blocked in the future, especially when cutting docs releases.

csantanapr commented 3 years ago

Sweet ! /approve /lgtm

omerbensaadon commented 3 years ago

CC: @evankanderson

omerbensaadon commented 3 years ago

PS: why does this doc live in the /website/ repo...?

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: csantanapr, omerbensaadon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/website/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment