knative / website

Hugo templates for the Knative website.
https://knative.dev
Other
23 stars 70 forks source link

[WIP] Initial setup for running the website in Docker #286

Open mpetason opened 3 years ago

mpetason commented 3 years ago

Changes

/kind documentation

Fixes #

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign abrennan89 after the PR has been reviewed. You can assign the PR to them by writing /assign @abrennan89 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/website/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mpetason commented 3 years ago

Looking on feedback:

mpetason commented 3 years ago

Addressed the review requests. Looking for more feedback on where this should live, right now it's website/docker. I don't know if that will cause any issues. It looks like the tests are failing right now due to another issue related to an addition recently.

knative-prow-robot commented 3 years ago

@mpetason: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.