Fixed spacing on code blocks

knative / website

Hugo templates for the Knative website.

https://knative.dev

Other

23 stars 70 forks source link

Fixed spacing on code blocks #289

Closed abrennan89 closed 3 years ago

abrennan89 commented 3 years ago

Fixes https://github.com/knative/docs/issues/2068

evankanderson commented 3 years ago

It looks like we added that padding on purpose to avoid scrollbars overlapping content:

https://github.com/knative/website/pull/27

It soundls like I might need a Mac to repro/determine this is no longer needed.

evankanderson commented 3 years ago

It appears Chrome now only shows the scrollbar while it is being scrolled, which seems to fix this. Evidence:

Also, we're missing units on the "5".

I suspect this is the only difference between this file and themes/docsy/assets/scss/_code.scss, so we could probably delete this file if desired.

/lgtm /approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/website/blob/main/OWNERS)~~ [evankanderson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment