search

knative / website

Hugo templates for the Knative website.
https://knative.dev
Other
23 stars 70 forks source link

redirect development to new mkdocs #307

Closed csantanapr closed 3 years ago

csantanapr commented 3 years ago

redirect pre-release /development to mkdocs site Related to https://github.com/knative/docs/issues/3617

csantanapr commented 3 years ago

/assign @julz

csantanapr commented 3 years ago

I got it working you can test here select pre-release from drop-down https://60a5e3afe10b2100089354df--knative.netlify.app/v0.22-docs/

csantanapr commented 3 years ago

that /development folder is created here but i suppose just deleting it at the end has the same result: https://github.com/knative/website/blob/main/scripts/processsourcefiles.sh#L30

Thanks @RichieEscarez

I made the change to skip the build

omerbensaadon commented 3 years ago

@csantanapr did Richie's fix get applied...? I don't see the same lines in your commit

csantanapr commented 3 years ago

I did the change, then he had concerns with the change. Then I put it back to just delete the folder. The change right now is the one with he lowest risk.

omerbensaadon commented 3 years ago

I'm assuming we're all aligned then!

/lgtm /approve

CC: @RichieEscarez

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omerbensaadon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/website/blob/main/OWNERS)~~ [omerbensaadon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment