search

knative / website

Hugo templates for the Knative website.
https://knative.dev
Other
23 stars 70 forks source link

Add fallback redirects to Go docs #320

Closed benmoss closed 3 years ago

benmoss commented 3 years ago

Changes

Add a redirect rule as the final rule that will redirect user to Go docs under https://go.pkg.dev, so that for instance https://knative.dev/eventing would result in https://pkg.go.dev/knative.dev/eventing

I'm a little worried that this will result in users getting 404s from pkg.go.dev instead of the current Netlify 404 page, but it's kinda 6 of one half dozen of the other.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benmoss To complete the pull request process, please assign dprotaso after the PR has been reviewed. You can assign the PR to them by writing /assign @dprotaso in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/website/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment