search

knaughten / mitgcm_python

Python scripts designed for my Weddell Sea and Amundsen Sea configurations of MITgcm.
26 stars 17 forks source link

Add SO-WISE domain, add key exception #5

Closed DaniJonesOcean closed 3 years ago

DaniJonesOcean commented 3 years ago

Hi @knaughten. I've added my initial key for the SO-WISE (gyre) domain. I've verified that the box and filled-in bathymetry (no deeper than 6000 m) do show up in my bathymetry files.

I've also added an exception that triggers when the user puts in a key that is not on the list. On my first few uses, I was confused as to why the edit_mask program reported a successful execution without actually changing my files. I think it didn't recognise my key, because I hadn't restarted the iPython kernel to let my new changes take effect. On execution, the "if" statement would just get skipped entirely, and thus no edits were applied, despite the "success" message. This exception should stop that from happening.

I also removed the word "slightly" in one of the print statement, since my domain is going a lot further than 60°S. ; )

I hope that's helpful! Thanks. : )

knaughten commented 3 years ago

Thanks Dan, everything looks good!