knausb / vcfR

Tools to work with variant call format files
248 stars 54 forks source link

Update conversion documentation #149

Closed zkamvar closed 4 years ago

zkamvar commented 4 years ago

Based on a recent topic in the poppr forum, it has come to my attention that there is no documentation of why return.alleles = TRUE is needed, so I have added it here and I will add it to the next poppr release.

I have also added the conditional in the examples to check if adegenet is loaded since you have it in Suggests, but not Imports.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 67.391% when pulling dbf181589dc38dc1d0c1f57ebf47b3867dbcbdf1 on zkamvar:znk-update-export-docs into 0532d573673c28ec848b98a1d43bece86a1f6084 on knausb:master.

knausb commented 4 years ago

That's fantastic. Thanks Zhian!

zkamvar commented 4 years ago

Just curious: are there any plans to release this to CRAN any time soon? It was last updated in 2018.

knausb commented 4 years ago

I don't have any specific plan (i.e., a date I'm aiming for). But I do recognize I'm overdue for a release to CRAN. I'd like to try to address some of the open issues first, but have been having trouble finding the time. I may have to settle for getting it out there and address issues in a future release.

zkamvar commented 4 years ago

I may have to settle for getting it out there and address issues in a future release.

No shame in small incremental updates!