dplyr 1.0.0 fixes - Githubissues

knausb / vcfR

Tools to work with variant call format files

248 stars 54 forks source link

dplyr 1.0.0 fixes #157

Closed hadley closed 4 years ago

hadley commented 4 years ago

ifelse() returns a logical vector if the Type is length 1; if_else() returns a character vector. dplyr 1.0.0 is stricter about combining types so this becomes an error. This shouldn't affect vcfR with the CRAN version of dplyr.

I had to guess at the value of the third argument; you should double check it.

coveralls commented 4 years ago

Coverage remained the same at 67.486% when pulling 2905450498c35cc6353fa78a5510f43c447e552e on hadley:dplyr-1.0.0 into f018f634895c5ac98dfabe6445e77d51f6fd7f22 on knausb:master.

knausb commented 4 years ago

In the past I've invited folks who provide a pull request to be included as a contributor. If @hadley would like to be included as a contributor please let me know. Working on testing and getting this update to CRAN. Thank you! Brian