search

kndndrj / nvim-dbee

Interactive database client for neovim
GNU General Public License v3.0
710 stars 48 forks source link

Add gcloud spanner driver #11

Open arnevm123 opened 1 year ago

arnevm123 commented 1 year ago

Hello, I'm interested in having access to this driver. When I find the time, I might attempt to implement it myself. If creating this driver (or issue) is not something you want, please inform me.

arnevm123 commented 1 year ago

In addition to this, is there a contributing guideline?

The only other project I have contributed to was null-ls. Theirs is pretty straight forward, but of course should be adjusted.

https://github.com/jose-elias-alvarez/null-ls.nvim/blob/main/doc/CONTRIBUTING.md

kndndrj commented 1 year ago

Hey, I already replied to the PR.

To address the contribution guidelines, I still need to come up with something.

For starters - markdown style, luacheck and stylua must pass (look into .github directory)

In the future, linting go should definitely be something + passing tests probably.

Another thing is that pull requests should have narrow focus - in my current pull requests this isn't somethig I'm sticking to, but for future contributions it should be followed probably.

Thanks for bringing these up btw. I really appreciate it 😄