search

kndndrj / nvim-dbee

Interactive database client for neovim
GNU General Public License v3.0
710 stars 48 forks source link

feature: Add gcloud spanner driver #12

Closed arnevm123 closed 10 months ago

arnevm123 commented 1 year ago

Hi, I made a draft for the Gcloud Spanner driver. I still need to make a dummy DB and test everything. For now this is mostly a copy-paste and I'll have to do some research to get the correct queries to load table names etc.

I've also added a linting file and did some edits accordingly. This of course is a bit opinionated, so if you want me to revert some of (or even all) these changes, add or delete rules, ... Please let me know and I'll be happy to do so 😄

kndndrj commented 1 year ago

@arnevm123 Thanks a lot for the contribution. At a first glance the implementation looks nice.

However due to this project being in a very early stage I'd ask you to remove the linting stuff and other style changes from this PR and isolate it to just implementing the spanner driver.

I'm very happy about your enthusiasm and I'd be very happy to work on linting in a separate pull request if you are willing to implement it.

I still need some time for a propper review and will definitely come back to you.

Thanks a lot!

arnevm123 commented 1 year ago

@kndndrj Yeah, I kinda realised I got carried away 😅 I'll focus on the spanner driver first. I can implement into the linting for you, I can work on some very small golangci file we can enforce without code changes and add that as a github action. No need to review this yet. I'll mark this as done when I've made this fully functional.

kndndrj commented 1 year ago

Sounds good! Then I come back once you finish. Let me know if you need any help :)

Regarding the linting file - i agree to have a small golangci file. I want to move some parts of github actions around in the future, so let's open an issue about this first, before implementing a pull request 😄