search

kndndrj / nvim-dbee

Interactive database client for neovim
GNU General Public License v3.0
710 stars 48 forks source link

Add BigQuery support #20

Closed dabbertorres closed 1 year ago

dabbertorres commented 1 year ago

I had a use-case for this, and decided to try hacking at the code to support BigQuery, and found it rather straightforward to implement.

Figured I'd share it upstream if there's interest.

I tried to follow the patterns for the existing implementations - let me know if I missed anything.

kndndrj commented 1 year ago

Hey @dabbertorres, thanks for the contribution!

At a first glance the changes look good, I'll have a closer look when I have some time!

dabbertorres commented 1 year ago

Sounds good, I'll take a look at resolving the checks in the meantime!

The build failures appear to be from unsupported architectures for the sqlite3 driver, while the Lua style checking failure is from changes made in an earlier commit.

kndndrj commented 1 year ago

@dabbertorres Don't worry about the CI checks - its just implemented to try and build everything.. I have a plan to address this in the future.

Otherwise, the PR looks fine, there is maybe a style difference, but I didn't enforce any guidelines yet, so I don't see any reason not to merge this.