Closed kndndrj closed 1 year ago
@MattiasMTS I hope you don't mind me opening this PR. I have a small commit, which addresses your comment. If you give me push permissions for this pr, I can push it.
@MattiasMTS I hope you don't mind me opening this PR. I have a small commit, which addresses your comment. If you give me push permissions for this pr, I can push it.
I sent you an invitation request as a collaborator just now! Let me know if that works. Feel free to delete the leftover commit 36fb188 since it is not meant to be in this one.. My bad.
Here is the commit, feel free to overwrite it if you see fit
Here is the commit, feel free to overwrite it if you see fit
Awesome! I'll probably take a look at this on Sunday (busy tonight and tomorrow hehe). Thanks for the commit!! 😃
No rush. I also won't be able to spend any time on this fora while
Ready for review @kndndrj . I left the implementation of this PR to only add the query progress bar - otherwise, it might have been messier..
Here are some video examples of how it looks like. Feel free to try it out.
https://github.com/kndndrj/nvim-dbee/assets/86059470/d6492898-c8f2-41e2-bf4d-e6a54fdc1cda
https://github.com/kndndrj/nvim-dbee/assets/86059470/315f3f24-432a-47fd-82de-220b87c0ccd6
@MattiasMTS Looks very pretty! I agree to narrow the scope of this PR to a single feature as well.
I need to test it first, but otherwise it looks ok!
Since this is a pretty straight forward feature I'll use this branch to do the changes if i find something is not working (if you don't mind ofcourse)
same here, just moved some stuff around, the way it makes more sense for me.
Thanks again!
adds progress ticker
cancel query?