search

kndndrj / nvim-dbee

Interactive database client for neovim
GNU General Public License v3.0
617 stars 40 forks source link

feat: query cancellation #44

Closed MattiasMTS closed 6 months ago

MattiasMTS commented 9 months ago

Added Dbee_cancel function. This cancels the latest running query.

I'm opening this as draft, as I need to fix a bug of when you cancel the query you receive "bad connection" on the next query, but the 2nd attempt works..

Feel free to add any commits you see fit @kndndrj

Also, perhaps it is worth refactoring the frontend Lua a bit? I kind of like the style vim-dadbod-ui has, e.g. on action "list" you insert it into the editor and execute it from there etc. Separate the ownership a bit on what the drawer/editor/result should do.

Additionally, if you've time - could you add a CONTRIBUTING.md file, where logic such as how to run this locally to see debugging messages etc, exists? 😄

kndndrj commented 9 months ago

Hey, thanks a lot, however I spent a lot of time on this already and have found a lot of bad design decisions along the way. So I'm basically refactoring the whole thing.

I would really like to have your review once I'm done with those changes though :D

MattiasMTS commented 9 months ago

I'm basically refactoring the whole thing.

Love it. Haha ❤️ No stress, I just had an hour left today and added this - so not that much work went into it heh..

I would really like to have your review once I'm done with those changes though :D

For sure! Just reach out on linkedin if you want to iterate together and "ball some ideas" etc. I definitely think this plugin will be the next db-plugin for neovim since "it just makes sense" 😄

kndndrj commented 6 months ago

closing in favor or #55