search

kndndrj / nvim-dbee

Interactive database client for neovim
GNU General Public License v3.0
617 stars 40 forks source link

[bigquery] Cannot finish fetching results with BigQuery resource #67

Open austinjonestucker opened 6 months ago

austinjonestucker commented 6 months ago

There seems to be an issue with the BigQuery adapter, where the results are not able to render fully. This seems possibly due to how the BigQuery row iterator is used in relation to the hasNext check required for iterators.

Failed retrieving results after 0.753 seconds
Reason:
    no more items in iterator

Running a minimal example to reproduce (no additional connection configuration needed, except : bigquery-nvim-dbee-cannot-get-results.

I noticed that in the result go code, there is this part where hasNext would be used after the results builder is generated -> https://github.com/kndndrj/nvim-dbee/blob/master/dbee/core/result.go#L49-L58 and wonder if the native BigQuery Done error being returned here -> https://github.com/kndndrj/nvim-dbee/blob/master/dbee/adapters/bigquery_driver.go#L55-L61 is incorrectly being interacted with.

ashish10alex commented 6 months ago

+1 on the above issue. The query is definitely being executed on BigQuery but not able to render the results