kndndrj / nvim-dbee

Interactive database client for neovim
GNU General Public License v3.0
617 stars 40 forks source link

refactor: return empty Columns #68

Closed MattiasMTS closed 6 months ago

MattiasMTS commented 6 months ago

nit improvement to return empty columns for the cmp instead of error. Mainly because returning error results in neovim error and not "silencing" it. Just a bit smoother experience 😋

The other refactoring just nice to have from the linter haha

kndndrj commented 6 months ago

Thanks, but I don't think this is a goof idea. A user can always call pcall and silence the error. With this PR we take ghat choice away

MattiasMTS commented 6 months ago

Ah nice. I’ll try that then.