search

kndndrj / nvim-dbee

Interactive database client for neovim
GNU General Public License v3.0
617 stars 40 forks source link

chore: update `Structure` and `Columns` for duckdb driver #77

Open MattiasMTS opened 5 months ago

MattiasMTS commented 5 months ago

🏗️ what has changed 🏗️

Using this as testing for the autocompletion plugin 😋

kndndrj commented 3 months ago

Overall changes look good!

But (yes, sorry 😅) I think I noticed somewhere that duckdb versions won't be backwards compatible before v1. So it probably makes sense to keep the previous version until v1. Correct me if I'm wrong though :)

Otherwise this can get merged.

MattiasMTS commented 3 months ago

Overall changes look good!

But (yes, sorry 😅) I think I noticed somewhere that duckdb versions won't be backwards compatible before v1. So it probably makes sense to keep the previous version until v1. Correct me if I'm wrong though :)

Otherwise this can get merged.

Ok, so we make a new driver for v1?

kndndrj commented 3 months ago

Are these changes relevant for current version as well?

MattiasMTS commented 3 months ago

Are these changes relevant for current version as well?

Hmm not sure. I think so but I can double check whenever I've some time.

kndndrj commented 2 months ago

Hey, @MattiasMTS

It has come to my attenrion that version 0.10 of duckdb started backwards compatibility.

So if you can update to the latest driver and verify that everything works, this PR is good to go!!

MattiasMTS commented 2 months ago

Hey, @MattiasMTS

It has come to my attenrion that version 0.10 of duckdb started backwards compatibility.

So if you can update to the latest driver and verify that everything works, this PR is good to go!!

Gotcha. I’ll try to carve out some time later today after work. Cheers.

MattiasMTS commented 2 months ago

I think it make more sense to merge this after merging #89. Mainly because I've introduced some core changes in the latter for the Structure func.

Let me know whatya think @kndndrj