search

kneasle / wheatley

An AI for Ringing Room that can ring any number of bells to increase the scope of practices.
https://pypi.org/project/wheatley/
MIT License
15 stars 13 forks source link

Line endings CRLF/LF #164

Closed centreboard closed 3 years ago

centreboard commented 3 years ago

https://github.com/kneasle/wheatley/pull/159#issuecomment-808427078 https://github.com/kneasle/wheatley/pull/159#issuecomment-808455694

On Windows a clean checkout will result in lots of linter warnings due to automatic CRLF conversion. I think we should suppress the warning rather than try and change default git and editor behaviour. We could then look at turning it on just as a pull request check.

kneasle commented 3 years ago

Hmm this is interesting. So does git convert all the line endings to CRLF? I don't really mind what happens, so long as we don't end up with files having mixed line endings since this seems pretty bad and my text editor can't deal with it.

I don't do anything development on Windows, so I'm happy for you to test this out and make a fix for it...