Make `That's All` more intuitive

kneasle / wheatley

An AI for Ringing Room that can ring any number of bells to increase the scope of practices.

https://pypi.org/project/wheatley/

MIT License

15 stars 13 forks source link

Make `That's All` more intuitive #181

Closed kneasle closed 3 years ago

kneasle commented 3 years ago

Fixes #103.

That's All now behaves more as people expect:

If we meet rounds within two clear rows, then stop
Otherwise jump to rounds after two clear rows (e.g. killing a touch half way/half a course of Cambs)

centreboard commented 3 years ago

Just running Wheatley in a single room this feels a bit less intuitive. If called in the middle of a touch Wheatley will currently start ringing rounds at the next handstroke. With this change if called at backstroke Wheatley will still ring the handstroke in the method.

I think this does improve touches that come round at hand, where That's all is called in the rounds handstroke.

kneasle commented 3 years ago

Just running Wheatley in a single room this feels a bit less intuitive...

Perhaps... the main issue people were having is that if That's All only takes effect at the next handstroke, then calling it too late would cause Wheatley to ring the first non-rounds row of the method and then snap back which several people have noted as irritating. I think I would rather support that use-case better at the expense of slightly unintuitive behaviour when calling That's All in the middle of a touch (which will hopefully be eventually superceded by the Rounds call anyway)... what do you think?

kneasle commented 3 years ago

/rebase

kneasle commented 3 years ago

Hmm OK so it looks like the auto rebase bot doesn't cause the PR checks to rerun...

centreboard commented 3 years ago

https://www.github.com/cirrus-actions/rebase/tree/3bd4fdcde2740cb0815bca85001f4369a7a5aebb/README.md

Mentions using a personal access token to instead of GITHUB_TOKEN

centreboard commented 3 years ago

Also that comment apparently triggered the rebase workflow...

kneasle commented 3 years ago

Mentions using a personal access token to instead of GITHUB_TOKEN

Ooh I'll fix that at some point... got bare work to do rn. I'll make an issue to remind me.

Also that comment apparently triggered the rebase workflow...

Ah yes it looks like the comment text is checked after the CI run starts. Kinda annoying really cos it massively clutters the CI action history.