search

kneasle / wheatley

An AI for Ringing Room that can ring any number of bells to increase the scope of practices.
https://pypi.org/project/wheatley/
MIT License
15 stars 13 forks source link

Make Wheatley understand `Rounds` #192

Closed kneasle closed 3 years ago

kneasle commented 3 years ago

Having campaigned with Bryn and Leland to have a call for Rounds added, I realise that we actually haven't implemented it yet. I think Rounds should behave in exactly the same way as That's All except that it always takes effect immediately and doesn't wait to check if rounds is reached naturally.

This would be a good first issue, since the codebase changes are entirely contained within the Bot class and most of the changes are already implemented for calls like Stand and That's All.

centreboard commented 3 years ago

I think Rounds should go back to opening rounds, while That's all goes to closing rounds

kneasle commented 3 years ago

I think Rounds should go back to opening rounds, while That's all goes to closing rounds

Ooh interesting idea... it does bug me slightly since the call is called Rounds not Starting Row, but for neeeearly all cases this doesn't matter 99% of touches will start and finish at rounds. But the call Rounds does implicitly mean 'the touch is gone so let's restart', in which case resetting to --opening-row is a good idea.