search

kneasle / wheatley

An AI for Ringing Room that can ring any number of bells to increase the scope of practices.
https://pypi.org/project/wheatley/
MIT License
15 stars 13 forks source link

Wheatley doesn't ring after the number of bells has been reduced #208

Open hillwithsmallfields opened 3 years ago

hillwithsmallfields commented 3 years ago

When I've changed the tower from 8 bells to 6, and press "l", I hear the "look to" announcement, but Wheatley doesn't ring anything. (The second is assigned to me, Wheatley has already "filled in" on all other bells). Also, on switching the tower back from 6 to 8 bells, Wheatley just rings up to 6.

kneasle commented 3 years ago

Hmmm I've definitely encountered this before, but I don't know how it's happening. If we could find a way to reliably reproduce it, then it would probably be relatively easy to crack.

hillwithsmallfields commented 3 years ago

I've had it happen twice now. Both times, if I close the page and open it again immediately, the problem is still there; but if I close it and come back a while later, the problem has gone.

On Tue, Aug 17, 2021 at 8:52 PM Ben White-Horne @.***> wrote:

Hmmm I've definitely encountered this before, but I don't know how it's happening. If we could find a way to reliably reproduce it, then it would probably be relatively easy to crack.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kneasle/wheatley/issues/208#issuecomment-900585872, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA22HXCDY67HPNYCONMP2BLT5K4XNANCNFSM5CKQHYZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

hillwithsmallfields commented 3 years ago

I've experimented a bit more, and sometimes Wheatley will ring some of the bells after a change in the number of bells, but the "Stop touch" button disappeared.

On Tue, Aug 17, 2021 at 8:59 PM John Sturdy @.***> wrote:

I've had it happen twice now. Both times, if I close the page and open it again immediately, the problem is still there; but if I close it and come back a while later, the problem has gone.

On Tue, Aug 17, 2021 at 8:52 PM Ben White-Horne @.***> wrote:

Hmmm I've definitely encountered this before, but I don't know how it's happening. If we could find a way to reliably reproduce it, then it would probably be relatively easy to crack.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kneasle/wheatley/issues/208#issuecomment-900585872, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA22HXCDY67HPNYCONMP2BLT5K4XNANCNFSM5CKQHYZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

kneasle commented 3 years ago

I've had it happen twice now. Both times, if I close the page and open it again immediately, the problem is still there; but if I close it and come back a while later, the problem has gone.

Ah this is probably because the Wheatley instance in your room doesn't disappear when everyone leaves - instead the Wheatley instances terminate automatically after 5 minutes of inactivity. Speaking of which, does the 'Reset' button fix the problem? The Reset button will hopefully be less temperamental now that lelandpaul/ringingroom#258 has been merged.

It sounds to me like this entire problem is a symptom of Wheatley somehow not picking up the tower size changes, and then panicking when trying to ring e.g. Major on 6 bells. I can't think of any way that this could happen (otherwise that way would probably already be fixed).