Open lelandpaul opened 1 year ago
Not entirely sure how you'd like to handle the build failures. Some are due to the incompatibility with currently-released RR; others look like just incompatibility with python 3.6, but I'm not sure I intend to continue supporting that on RR. Let me know if you need me to do anything more.
incompatibility with python 3.6, but I'm not sure I intend to continue supporting that on RR
I think we can drop python 3.6 support since lot's of other packages have dropped support.
This has been tested against a local build of Ringing Room; it will fail against the production RR due to backwards-compatibility issues in socketio.
Not entirely sure how you'd like to handle the build failures
The version of socketio & engineio required when installing Wheatley via PIP is controlled by setup.py
https://github.com/kneasle/wheatley/blob/af86f4f81c3ee3ff15ef4092d0832f748af1396c/setup.py#L33-L34
Since this will be a breaking change for Wheatley and ringing room a process for this could be
1) Just update setup.py in Wheatley, and publish this a a pre-release to pypi 0.8.0b1
. This won't work with the current production ringing room
2) Update Ringing room socketio, using the pre release Wheatley
3) Merge in this PR and publish Wheatley 0.8.0
, encouraging command line users to update
That process seems good to me. I've gone ahead and bumped the versions in setup.py
I've published https://pypi.org/project/wheatley/0.8.0b1/ to allow RingingRoom to update with that version
I'm working on a variety of version-bumps for Ringing Room. This will require Wheatley to use the latest socketio versions.
This has been tested against a local build of Ringing Room; it will fail against the production RR due to backwards-compatibility issues in socketio.