search

kneath / kss

A methodology for documenting CSS and generating styleguides.
warpspire.com/kss
MIT License
4.04k stars 275 forks source link

General spec cleanup #107

Open JohnAlbin opened 9 years ago

JohnAlbin commented 9 years ago

Here's the no-brainer spec clean-up bits (I hope!) from #106. I'll put the other changes in to their own PRs.

I kept them as separate commits, but I can rebase and squash them into 1 commit if you prefer.

JohnAlbin commented 9 years ago

Hmm… I just searched the entire repo and .star-given is what is used in the test fixtures. .stars-given is used in the README and SPEC. So, I'm going to guess that .star-given is the "correct" class name and use it consistently throughout.

Also, I've decided I'm going to rebase and squash to 1 commit. There's really not that much changed here.

JohnAlbin commented 9 years ago

This is good to go now. I've added comments to most of the line changes on the files tab: https://github.com/kneath/kss/pull/107/files

JohnAlbin commented 9 years ago

Naturally, there would be a ton of merge conflicts if I pushed all the changes from #106 into your PR queue. So I've queued up all the dependent branches at https://github.com/kss-node/kss/branches/all?query=spec- and I'll push new PRs as we resolve open PRs.

JohnAlbin commented 9 years ago

I-maintain-an-open-source-project-too-so-I-totally-understand-youre-not-getting-paid-to-review-my-pull-request-PING! :-)