kneath / kss

A methodology for documenting CSS and generating styleguides.
warpspire.com/kss
MIT License
4.04k stars 275 forks source link

Fix kneath/kss#39 #40

Closed alanhogan closed 12 years ago

alanhogan commented 12 years ago

Should make the pseudo-element selector display work with @extends.

I didn’t see any relevent tests, but this test input could be useful.

/*
Nothing much. It has no border but it has focus styles

:focus - Focus state

Styleguide 2.3.1
*/
.foo {
  border-width: 0;
}
.foo:focus, .foo-variant:focus {
  outline: 3px solid rgba(0,80,255, 0.4);
}

/*
Like foo, but fullwidth.

:focus - Focus state

Styleguide 2.3.2
*/
.foo-variant {
  width: 100%;
}

See kneath/kss#39

alanhogan commented 12 years ago

Just wanted to say that this fix does indeed work for me, and that the impatient can use it via a gem install kss-alan.

alanhogan commented 12 years ago

Anything I can do to get this merged in?

kneath commented 12 years ago

Rad, I'm cutting a new gem today. I'll get it out.

alanhogan commented 12 years ago

Which version of Chrome? Bug in their regex handling?

kneath commented 12 years ago

@sumitngupta An example would be great, it's been working great on Chrome for me.