Fix while loop issue that caused page to break

kneath / kss

A methodology for documenting CSS and generating styleguides.

warpspire.com/kss

MIT License

4.04k stars 275 forks source link

Fix while loop issue that caused page to break #48

Closed brianegan closed 11 years ago

brianegan commented 11 years ago

Howdy,

Saw you were using a "while" loop in the JS which was causing the example page to not render. Changed it to an if statement (like you have on the github style guide) and it started working again!

Best, Brian

deanpcmad commented 11 years ago

+1 this fixes the page hanging problem for me

kierzniak commented 11 years ago

+1 I have noticed this problem in chrome in ff everything was ok.

kainosnoema commented 11 years ago

+1 this is happening in both Chrome and Safari for me. Maybe a Webkit issue? The change from while to if fixes it.

zacparker commented 11 years ago

:+1: same problem

kneath commented 11 years ago

Can you look into the coffee file? The js file is only generated from the coffee file.

I'm a little dubious of this being an actual bug given how long this has been working. Are you guys perhaps running dev or nighly builds of webkit?

iainhenderson commented 11 years ago

:+1: This fixed my issue of Safari 6.0.2 and Chrome 24.0.1312.57 (Stable) crashing.

benschwarz commented 11 years ago

This is covered in a recent merge (#60). Thanks for the PR !