kneemaa / github-action-rotate-aws-secrets

Github Action to rotate AWS Access Keys stored in a repositories secrets
MIT License
37 stars 19 forks source link

convert to more Pythonic access of dicts #17

Closed tedder closed 2 years ago

tedder commented 2 years ago

Improving readability, fewer lines. Also used the py3.8 walrus since this action is on 3.8 anyhow.

Technically this changes logic, but it should be an improvement. I mean, "if FOO in dict" will be true even if the value of the entry is None or is ''. So this switches to a stringy truthiness.