Request for feedback! - Githubissues

knes1 / elktail

Command line utility to query, search and tail EL (elasticsearch, logstash) logs

MIT License

197 stars 66 forks source link

Request for feedback! #21

Closed bjornblomqvist closed 7 years ago

bjornblomqvist commented 7 years ago

Hi!

I have changed so that i can get all messages during a period 2017-01-01 -> 2017-01-05. So this fixes my problem i am know wondering what your thoughts are on my solution. Do you think i am on the right track? Do you feel there are missing tests ?

My hope is to merge this so that i can get rid of my custom version of elktail.

Best Regards Björn Blomqvist

knes1 commented 7 years ago

Thanks for PR!

I did a quick look at the code and it looks good. I will test it out as soon as I get a chance. How does this solution interact with -n option? I'm assuming it's currently ignoring it? I suppose it kind of makes sense to ignore -n if a full date range is specified... What is your opinion?

bjornblomqvist commented 7 years ago

The quality of this code is quite bad so will be closing this. I hope to return with new and more polished pull requests.

/Björn