knex / knex

A query builder for PostgreSQL, MySQL, CockroachDB, SQL Server, SQLite3 and Oracle, designed to be flexible, portable, and fun to use.
https://knexjs.org/
MIT License
19.22k stars 2.12k forks source link

Improve documentation by integrating VuePress #5915

Open kasvith opened 3 years ago

kasvith commented 3 years ago

Often when using Knex.js documentation I find it rather difficult to search for something. Also, the font size is too small. If we moved to a system like VuePress we get a lot of things out of the box

Objection.js is already using VuePress and I find it very easy to navigate and use.

By doing this I hope Knex documentation will be much accessible and pleasant to work with.

kasvith commented 3 years ago

I can personally take a look at this

kibertoad commented 3 years ago

@kasvith That would be amazing!

kasvith commented 3 years ago

@kibertoad are there any special things to tackle down transition? I checked source code and it seems a combination with React and Webpack.

I would love to work with this in my free time

kibertoad commented 3 years ago

Personally I'm a big fan of Vue.js, so definitely would be happy to switch over from React. I think most of the documentation is rather straightforward, the most dynamic one is probably this: https://github.com/knex/documentation/blob/gh-pages/components/Changelog.jsx

kasvith commented 3 years ago

Yes I also noticed that.

Since VuePress can create a separate page for changelog i dont see why we cant include full version there. LMK what you think :)

kasvith commented 3 years ago

Also, we can switch over to Netlify from GitHub. It's Faster and even allows us to have [https://staging.knexjs.org]() based on branches.

I feel it's a lot flexible and more suitable for the task. I will also add Netlify build commands so if you like we can switch over easily

kibertoad commented 2 years ago

@kasvith Either version works for me. And after we switch to Vuepress, sure, I would be open to consider Netlify.

kasvith commented 2 years ago

Cool, I was considering about the current hyperlinks as well. We will also need a way to make them work as its been used by many people for references

vencho-mdp commented 2 years ago

Hi! Is anyone working on this feature?

kasvith commented 2 years ago

@vencho-mdp i didnt have time to work on this, if you start let me know

vencho-mdp commented 2 years ago

Hi! I could do this along the week. Anyways, I just wanted to make sure that it would be useful. Could you confirm this? @kibertoad

kibertoad commented 2 years ago

@vencho-mdp It definitely would be!

vencho-mdp commented 2 years ago

Sounds Great! This'll be the repo: https://github.com/vencho-mdp/knexjs-docs-vuepress, I'll tell you when I finish it.

vencho-mdp commented 2 years ago

Hi @kibertoad ! Could you sign up for Algolia on this link https://docsearch.algolia.com/? If you do it, I'll we able to integrate Algolia Search :)