search

kni-labs / rrssb

:arrow_right_hook: Ridiculously Responsive Social Sharing Buttons
https://rrssb.netlify.com/
MIT License
3.4k stars 424 forks source link

Share counter added #117

Closed connorwyatt closed 9 years ago

connorwyatt commented 9 years ago

The current progress is that the share counter has been added, the icons load via ajax, but the buttons don't yet size.

I was going to modify the code from the original but if you're happy to do the sizing I'll leave it :)

connorwyatt commented 9 years ago

Just realised there is no documentation written for what I've done so far, I'll update the readme when I get chance

dbox commented 9 years ago

This is awesome. I like the no-js fallback.

connorwyatt commented 9 years ago

Yeah? I'm glad, it wasn't even intentional, I just realised that because it gets cleared before the buttons get added you can use it with no js

connorwyatt commented 9 years ago

Nice little accident there!

dbox commented 9 years ago

I just pushed to 2.0. Make sure you sync with upstream.

Also, after playing around with it, I think we leave it as index.html. Works better with the gulp server.

connorwyatt commented 9 years ago

I see, I will do.

Also I think I can change the default page that opens with the gulp server, so if you want to change it it won’t be a problem

On 29 May 2015, at 04:59, Daniel Box notifications@github.com wrote:

I just pushed to 2.0. Make sure you sync with upstream.

Also, after playing around with it, I think we leave it as index.html. Works better with the gulp server.

— Reply to this email directly or view it on GitHub https://github.com/kni-labs/rrssb/pull/117#issuecomment-106676674.