Tidy up SVG files - Githubissues

kni-labs / rrssb

:arrow_right_hook: Ridiculously Responsive Social Sharing Buttons

https://rrssb.netlify.com/

MIT License

3.4k stars 424 forks source link

Closed AdamPS closed 9 years ago

AdamPS commented 9 years ago

As far as I can tell the SVG icons can be optimised in various ways to remove some unneeded lines and tidy up.

Use square viewport (pocket) else the icon ends up slightly larger than all the others
Don't need width, height - set in CSS/JS
Don't need fill="#FFF" - set in CSS
Don't need preserveAspectRatio, class, fill-rule - only present on one or two icons and doesn't seem to have any effect.
For consistency, put viewport attribute after xmlns

AdamPS commented 9 years ago

Sorry I don't understand why I have 2 existing commits in my pull request.