search

kni-labs / rrssb

:arrow_right_hook: Ridiculously Responsive Social Sharing Buttons
https://rrssb.netlify.com/
MIT License
3.4k stars 424 forks source link

Add Whatsapp icon #162

Closed pascalwacker closed 8 years ago

pascalwacker commented 8 years ago

Hi

I really like your work and how nice it scales. The only thing, that is missing for me is a "Whatsapp" icon (which should only display on phones, so let's say when the resolution is <= 767px)

is there anything like that planed? If no, could you tell me, how to make an path from an icon, to add it?

Thanks (:

dbox commented 8 years ago

dup of #81 and #122. I'm fine with adding but we can't simply just remove it with a media query, will break the setup. Open to thoughts on what to do with it

pascalwacker commented 8 years ago

What's about hiding it in the $(window).resize(function () { on line 359 of https://github.com/kni-labs/rrssb/blob/master/js/rrssb.js You could add a class like hidden and then check for it in the checkSize function to ignore the "hidden" button.

Maybe it could be used as a general approach for hiding and showing buttons for desktop or mobile only.

j3ll3nl commented 8 years ago

With the button-code from #122 and the idea mentioned above this would be a great feature to have.

pascalwacker commented 8 years ago

Ouu, I haven't seen https://github.com/kni-labs/rrssb/issues/122 yet, but I also made an implementation and a pull request for it: https://github.com/kni-labs/rrssb/pull/166

dbox commented 8 years ago

Should be good to go in 1.10.0. Let me know if any issues arise! :tada: