Add print option. - Githubissues

kni-labs / rrssb

:arrow_right_hook: Ridiculously Responsive Social Sharing Buttons

https://rrssb.netlify.com/

MIT License

3.4k stars 423 forks source link

Add print option. #168

Closed froboy closed 8 years ago

froboy commented 8 years ago

Client wanted a print button. We loved RRSSB and so I thought I'd try and give back.

Print icon is via Google's Material Design Guide. I had some issues with the SVG since it's two paths and I couldn't reliably squish it into one, so there's an ugly line of CSS at the end of the file to override the styles for this icon. If anyone can point me to a better SVG, I'm happy to replace it.

I was kinda grumpy at the client for demanding a print button in 20-f-ing-16, so I used a color inspired by the golden age of printing.

dbox commented 8 years ago

Nice! Thnx. Mind posting a screenshot? (Not able to run the build atm)

froboy commented 8 years ago

ridiculously_responsive_social_sharing_buttons_by_kni_labs_and_ridiculously_responsive_social_sharing_buttons_by_kni_labs

dbox commented 8 years ago

Ha. cool. I'd probably go with a medium gray or cool gray, but I dig it. We can get this in.

On Thu, Feb 4, 2016 at 4:10 PM, Avi Schwab notifications@github.com wrote:

[image: ridiculously_responsive_social_sharing_buttons_by_kni_labs_and_ridiculously_responsive_social_sharing_buttons_by_kni_labs] https://cloud.githubusercontent.com/assets/238201/12831414/c2d60816-cb59-11e5-8f58-4a753ca659fb.png

— Reply to this email directly or view it on GitHub https://github.com/kni-labs/rrssb/pull/168#issuecomment-180073618.

froboy commented 8 years ago

Yea, I thought the palette could use a little green, but looking at it more it definitely doesn't quite fit in. Doubt the client will go for my rage-green anyway... How's "dead-tree charcoal"?

dbox commented 8 years ago

froboy commented 8 years ago

Works for me...

dbox commented 8 years ago

Thanks @froboy! :ship: :tada: