Optimise icons - Githubissues

kni-labs / rrssb

:arrow_right_hook: Ridiculously Responsive Social Sharing Buttons

https://rrssb.netlify.com/

MIT License

3.4k stars 424 forks source link

Optimise icons #186

Closed AdamPS closed 8 years ago

AdamPS commented 8 years ago

Similar to #130

Don't need width, height - set in CSS/JS
For consistency, put viewport attribute after xmlns
When setting fill, use style="fill" which persists whereas the ordinary fill gets overridden. Hence can remove special-case CSS 'hack'.

dbox commented 8 years ago

Thanks @AdamPS These are automatically getting squished through gulp so we'll need to make sure any edits are happening to the non .min files so that carries over to the gulp process.

AdamPS commented 8 years ago

Thanks. Patch includes both min and non-min files (or at least that was my intention - let me know if I missed something).

AdamPS commented 8 years ago

Thanks