search

kni-labs / rrssb

:arrow_right_hook: Ridiculously Responsive Social Sharing Buttons
https://rrssb.netlify.com/
MIT License
3.4k stars 424 forks source link

Are share counts working? #214

Closed mmautner closed 6 years ago

mmautner commented 6 years ago

I'm testing out the 2.0 branch with a very simple configuration:

    var options = {
       socialNetworks: ["linkedin", "facebook", "twitter", "reddit"],
       url: "some-valid-url",
       showCount: true,
    };
    $(".rrssb-container").rrssb(options);

And am noticing the following:

screen shot 2017-12-13 at 8 29 06 pm

I suppose share counts broke after something changed about the Twitter API--is this library still aiming to support share counts? Or maybe should it be dropped from 2.0?

Related: https://github.com/kni-labs/rrssb/issues/49

Thank you @dbox for the work you've put into it, very nice library :)

mmautner commented 6 years ago

I'll just comment on #49