Would be nice if total counts can be displayed in a small box before or after the buttons

bboerendans commented 10 years ago

Total sharing counts can be tracked with www.sharedcount.com. So we can show something like:

naamloos

I have no idea how to fix this, but i thought maybe its a nice idea :)

bboerendans commented 10 years ago

And if you don't want to use a thirdparty for getting total shares, you can use something like https://gist.github.com/mhawksey/3833072 or http://99webtools.com/script-to-get-shared-count.php for getting total shares.

dbox commented 10 years ago

This would be cool option for sure. I wonder if there is a JS-only way to do it?

bboerendans commented 10 years ago

Maybe Sharrre ( https://github.com/Julienh/Sharrre)? Sharrre works only with JS as far as I can see. With some small modifications, someone will be able to get the total sharings count I guess. Op 20 aug. 2014 20:54 schreef "Daniel Box" notifications@github.com:

This would be cool option for sure. I wonder if there is a JS-only way to do it?

— Reply to this email directly or view it on GitHub https://github.com/kni-labs/rrssb/issues/49#issuecomment-52825002.

dbox commented 10 years ago

Nice!

bboerendans commented 10 years ago

If someone is able to build this, I think the count of total shares before the buttons is the most preferable option. Because otherwise on mobiles the first button is mostly on max width. If someone needs me for testing, let me know because I am not able to configure this by myself. Op 20 aug. 2014 22:12 schreef "Daniel Box" notifications@github.com:

Nice!

— Reply to this email directly or view it on GitHub https://github.com/kni-labs/rrssb/issues/49#issuecomment-52836635.

ksweetie commented 10 years ago

So I just kind of integrated rrssb with sharrre tonight on my personal site. You can see an example at http://www.kevinsweet.com/my-bucket-list/. Sharrre by default adds a total from all the social networks, but I didn't want that, so I modified the code to let me grab the individual shares.

Just a heads up if anyone else is wanting to do this or something similar. Some social networks don't work with only Javascript, such as Google Plus. Sharrre uses a PHP file to curl and process the response from those social networks.

If you were able to setup rrssb though, you can easily add Sharrre and get a total count from at least the social networks that support jsonp (most except G+). You can look through the code for my site if you want https://github.com/DynamicDyno/dynamicdyno.github.io.

jnessier commented 9 years ago

+1, great idea!

dbox commented 9 years ago

share-counter image I'm okay with adding the top version as an option in the js, if anyone is up for taking it on. Will need to be added to 2.0 branch.

connorwyatt commented 9 years ago

I'll have a look into this, I have a good idea of how to get it done. I did something similar before I found RRSSB.

dbox commented 9 years ago

Awesome. If you do get something going, would you mind pushing up to 2.0 branch?

dbox commented 9 years ago

Want to keep this separate for a bit until we can fix #75 as part of the last big 1.x.x

connorwyatt commented 9 years ago

No worries I will do and I'll have a look at #75 too On 20 May 2015 19:50, "Daniel Box" notifications@github.com wrote:

Want to keep this separate for a bit until we can fix #75 https://github.com/kni-labs/rrssb/issues/75 as part of the last big 1.x

— Reply to this email directly or view it on GitHub https://github.com/kni-labs/rrssb/issues/49#issuecomment-103992710.

connorwyatt commented 9 years ago

@dbox I'm looking at the js and I think it might be best to do a rewrite of it. The functions would stay in it but it would end up as a plugin where you would call it like this (with more options of course):

<body>

  <div class="rrssb-container></div>

  <script>

    var options = {
      socialNetworks: [ "facebook", "twitter", "linkedin", "email" ],
      showCount: true
    };

    $(".rrssb-container").rrssb( options );

  </script>

</body>

What do you think of that?

The social network buttons would be created by the js plugin by specifying them in the order you want them to appear in the options.socialNetworks property.

Might allow some more customisability?

dbox commented 9 years ago

I think this makes a lot of sense. Would definitely be easier for someone to implement. The only downside is not being able to manually edit the meta info in html, but I think that is probably okay.

I'm going to start a new 2.0 thread to capture everything.

connorwyatt commented 9 years ago

I'm glad, I started working on it a little bit today and I will implement optional overrides so you can feed in your own twitter status or Facebook status etc. Otherwise it will use the page's title and description along with the url On 21 May 2015 14:37, "Daniel Box" notifications@github.com wrote:

I think this makes a lot of sense. Would definitely be easier for someone to implement. The only downside is not being able to manually edit the meta info in html, but I think that is probably okay.

I'm going to start a new 2.0 thread to capture everything.

— Reply to this email directly or view it on GitHub https://github.com/kni-labs/rrssb/issues/49#issuecomment-104279208.

dbox commented 9 years ago

The Meta already has settings in the .js...

connorwyatt commented 9 years ago

What do you mean?

dbox commented 9 years ago

// Settings that $.rrssb() will accept.
  var settings = $.extend({
    description: undefined,
    emailAddress: undefined,
    emailBody: undefined,
    emailSubject: undefined,
    image: undefined,
    title: undefined,
    url: undefined
  }, options );

dbox commented 9 years ago

I guess that can get called with the plugin.

connorwyatt commented 9 years ago

Yeah thats where I'm going to put them all. I'll add in other options for changing the text shown in individual social networks' buttons.

So for example there will also be an option for linkedinTitle that will override the default which will be the page title, along with others

connorwyatt commented 9 years ago

So if you dont want the linked in title to be the page name you can call it like this:

$(".rrssb-container").rrssb({
  linkedinTitle: "This is a different title for LinkedIn only."
});

connorwyatt commented 9 years ago

But all others (FB, twitter etc.) will use the default. This way you can change the share message

dbox commented 9 years ago

It should be 2-tiered, though right?

If nothing set > use current page meta. If title set> Used title for linkedinTitle, then if linkedinTitle set, obviously use that.

That being said, I'm not even sure if I care about specific titles per sites. Not sure anyone would even need that.

connorwyatt commented 9 years ago

Yeah that's exactly right, it is 2-tiered, and that's not a problem, by default it will use the page title and description from the html

dbox commented 9 years ago

While I'm thinking about this: I think it's okay to have the share-count defaulted to visible, but only if it has 1 or more share(s).

connorwyatt commented 9 years ago

It’s a good idea, but then you have the overhead of http requests that are never used. I can do it if you want though

On 29 May 2015, at 05:51, Daniel Box notifications@github.com wrote:

While I'm thinking about this: I think it's okay to have the share-count defaulted to visible, but only if it has 1 or more share(s).

— Reply to this email directly or view it on GitHub https://github.com/kni-labs/rrssb/issues/49#issuecomment-106684499.

dbox commented 9 years ago

Np. Let's table for now

mmautner commented 6 years ago

I'm testing out the 2.0 branch with a very simple configuration:

    var options = {
       socialNetworks: ["linkedin", "facebook", "twitter", "reddit"],
       url: "some-valid-url",
       showCount: true,
    };
    $(".rrssb-container").rrssb(options);

And am noticing the Twitter API that's hit no longer appears to be supported circa 2015:

Is this library still aiming to support share counts? Or maybe should it be dropped from 2.0?

Thank you @dbox for the work you've put into it so far 👍

kni-labs / rrssb

Would be nice if total counts can be displayed in a small box before or after the buttons #49