search

kni-labs / rrssb

:arrow_right_hook: Ridiculously Responsive Social Sharing Buttons
https://rrssb.netlify.com/
MIT License
3.4k stars 424 forks source link

Enhancement and URL Update #87

Closed andrewicarlson closed 9 years ago

andrewicarlson commented 9 years ago

Updated index.html to use the new tumblr sharing link.

Updated rrssb.js per https://github.com/kni-labs/rrssb/issues/47 to accept:

$('.example').rrssb({ description: '', emailAddress: '', emailBody: '', emailSubject: '', image: '', title: '', url: '' });

Also included a function for recursively decoding the strings and encoding a single time.

This should be fully backwards compatible, the function doesn't need to be run for RRSSB to function properly as long as the links have data in them already, but it's a nice override.

dbox commented 9 years ago

Awesome! I'll get this pulled in later today. On Fri, Apr 10, 2015 at 8:59 PM Andrew Carlson notifications@github.com wrote:

Updated index.html to use the new tumblr sharing link.

Updated rrssb.js per #47 https://github.com/kni-labs/rrssb/issues/47 to accept:

$('.example').rrssb({ description: '', emailAddress: '', emailBody: '', emailSubject: '', image: '', title: '', url: '' });

Also included a function for recursively decoding the strings and encoding a single time.

This should be fully backwards compatible, the function doesn't need to be run for RRSSB to function properly as long as the links have data in them

already, but it's a nice override.

You can view, comment on, or merge this pull request online at:

https://github.com/kni-labs/rrssb/pull/87 Commit Summary

  • Meta attributes as variables
  • Update rrssb.js
  • Update index.html

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/kni-labs/rrssb/pull/87.

dbox commented 9 years ago

in! i think in the future we need to do all pull requests to /dev. so I can just merge automatically.

andrewicarlson commented 9 years ago

I saw that, thanks! Ok, sorry about that. I'll pull to /dev in the future.