search

knieper / crltmich

0 stars 0 forks source link

prevent and remove duplicate certificate nodes arising from event attendance updates #8

Closed anjirlly closed 8 years ago

anjirlly commented 8 years ago

Restoring lost functionality

1) PREVENT When a certificate node already exists, and the event attendance is updated, don't let it create another certificate.

Relevant field field_certificate_source and field_certificate_source_id The source is signup. source_id is node number of event

2) REMOVE Find nodes previously created in duplicate and eliminate them, with attention to any difference in workflow state among duplicated nodes.

For example, if nodes that appear to be duplicates have different workflow states, then we'd need to discuss logic of which one to delete, but we note that all such nodes are expected to have the workflow state of approved.

mbakewel commented 8 years ago

duplicate nodes are not being created - so that part is resolved. However, new certificate nodes are created with workflow state = 'New request = awaiting review" instead of "Approved" They are set to approved if the attendance is re-set to attended after the certificate node was created.

knieper commented 8 years ago

I just did a test event, test sign up and then a test 'marked attended' and it gets set correctly.

image

I may be misunderstanding

mbakewel commented 8 years ago

The issue is fixed. However, we (jeri and I ) both got a spinning blue "hourglass" when trying to make attendance in bulk on the node, see screenshot. image

knieper commented 8 years ago

Did it hang there forever? or was it momentary?

mbakewel commented 8 years ago

forever! at least > 2-3 minutes. It did this for me and for Jeri.

On Mon, Apr 4, 2016 at 12:54 PM, Sharon Knieper notifications@github.com wrote:

Did it hang there forever? or was it momentary?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/knieper/crltmich/issues/8#issuecomment-205390711

Meg Bakewell, Ph.D. Assistant Director Center for Research on Learning and Teaching (CRLT)

knieper commented 8 years ago

Was never able to reproduce the hanging hourglass behavior. I wonder if it was connected to the issues seen with the white screen of death?. Closing until additional reports come in.