knightcrawler-stremio / knightcrawler

A selfhosted Stremio addon
Apache License 2.0
308 stars 44 forks source link

Unify docker-compose.yaml and remove un-needed stack.env file plus drop in replacments for postgres and redis and my own build of qBittorrent #202

Closed eoghan2t9 closed 6 months ago

eoghan2t9 commented 7 months ago

Change Postgres to Citus drop in replacement https://www.citusdata.com/

Change Redis to drop in fully open source replacement KeyDB and enable 4 threads. https://docs.keydb.dev/

Change qBittorrent to my own build of Linuxserver.io that already includes the qBittorrent.conf https://github.com/eoghan2t9/docker-qbittorrent

FunkeCoder23 commented 7 months ago

stack.env was purposefully used 1. because users don't have to mess with compose.yml directly and 2. because portainer stores variables in stack.env (which is why it's not just .env) Moving all of the variables inside of the compose defeats these two points

FunkeCoder23 commented 7 months ago

Can you elaborate the benefits of these replacements?

Also, it seems odd to replace the lsio version with your version. configs are easy enough to add, why do we need your build?

eoghan2t9 commented 7 months ago

It's more my OCD head I've looked at it like what's the point of having the stack.env file when it can be added the way I have done. It's like going to the sink and filling two glasses of water half full only to pour one into the other 😂. As for the custom build of qbittorrent again just pure ease of use go users could essentially run curl or wget against the raw link to the compose file and pipe it into docker to bring up the containers. Also they can simply copy and paste the full compose file into the likes of portainer or whatever docker management gui they want.

I am also currently making an advanced compose file for users that want all the bells and whistles like gluetun and a postgres webui etc.

d3mystified commented 6 months ago

All this seems very unnecessary

FunkeCoder23 commented 6 months ago

@purple-emily I think you can close this