search

knightcrawler-stremio / knightcrawler

A selfhosted Stremio addon
Apache License 2.0
265 stars 38 forks source link

Add support for securing my self hosted instance when exposed externally with Nginx Proxy Manager http basic auth with SSL certificate. #85

Closed ben-2357 closed 7 months ago

ben-2357 commented 8 months ago

Is your feature request related to a problem? Please describe. I cannot install KnightCrawler as an addon in Stremio with http basic auth enabled (also with SSL certificate). I have tried passing the credentials in the URL like this; https://user:password@knightcrawler.mydomain.com but it doesn't work. Is there any other solution than using a VPN to connect to my instance?

Describe the solution you'd like A way to keep other people out of my KnightCrawler instance.

Describe alternatives you've considered Using a VPN. I don't want to do this, because it really defeats the purpose of Real Debrid.

Additional context Stremio responds with something along the lines of; Error adding addon to catalog.

purple-emily commented 7 months ago

I can’t confirm if basic with works with Stremio but if you poke me on our discord I can help check your setup @ben-2357

purple-emily commented 7 months ago

@ben-2357 you’ll likely need to make a slightly altered build to get this to run right now. I am dealing with a family issue but I will add the support to make this work for you when I’m free

purple-emily commented 7 months ago

@ben-2357 i can likely instruct you in how to get this working if you want it doing now, again discord would be a lot easier

trulow commented 7 months ago

@ben-2357 What does your config look like?

I've been using knightcrawler with nginxproxymanager since the start and it's been working fine on my end.

EDIT: Ah, nevermind. You're using basic auth. I've enabled access lists limited to my home IP network. You could try that method instead.

ben-2357 commented 7 months ago

Does that still allow external access though?

trulow commented 7 months ago

@ben-2357 It can, however only to networks you define with the allow variable. If trying to access on a network that is not defined, it'll deny access.

Gabisonfire commented 7 months ago

Does the basic auth works to reach the addons when using your browser?

ben-2357 commented 7 months ago

Yes, basic auth works great, and I can access everything in the browser fine. I think Stremio itself rejects the basic auth passed into the URL and also fails to 'plug' it back into the URL when needing to connect to the addon webpage.

Gabisonfire commented 7 months ago

Yeah that's more of a Stremio issue than a Knightcrawler issue. I'll wait to see if @purple-emily can get something working otherwise we should move this issue to their repos.

purple-emily commented 7 months ago

I also believe it's a Stremio issue. I suggest opening an issue there