knightcrawler-stremio / knightcrawler

A selfhosted Stremio addon
Apache License 2.0
265 stars 38 forks source link

GitHub action is not tagging the images as latest #87

Closed purple-emily closed 7 months ago

purple-emily commented 7 months ago

image

I am having to manually tag the images as main at the moment. Can anyone see why the latest tag isn't being done?

sleeyax commented 7 months ago

According to the docs, the latest tag is only automatically added for type ref, semver and match in https://github.com/Gabisonfire/torrentio-scraper-sh/blob/2cae5296a221bd7c489632fcfa2721aabc9bec9c/.github/workflows/build_images.yaml#L62. We don't use any of those. Reading further:

You can also use the {{is_default_branch}} global expression to conditionally tag with latest for the default branch

So if we add that it should work. I'll create a PR.

purple-emily commented 7 months ago

Closed by #90 hopefully